Re: [PATCH 1/1] Staging: gdm724x: code style improvements
From: Tolga Ceylan
Date: Fri Feb 13 2015 - 17:07:45 EST
On Fri, Feb 13, 2015 at 1:05 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> You're doing too many things at one. This should probably be split into
> 7 patches.
I will split this up and resubmit.
>> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>> if (ed->dev_ed == ed->host_ed)
>> return x;
>> - return Endian16_Swap(x);
>> + return ENDIAN16_SWAP(x);
> All the changes are good except these. We have standard macros
> cpu_to_be16()/le16() and back for these.
> dan carpenter
Thanks, I'll skip this one.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/