Re: [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring

From: James Morris
Date: Sun Feb 15 2015 - 21:27:56 EST

On Thu, 12 Feb 2015, David Howells wrote:

> From: David Jeffery <djeffery@xxxxxxxxxx>
> If a request_key() call to allocate and fill out a key attempts to insert the
> key structure into a revoked keyring, the key will leak, using memory and part
> of the user's key quota until the system reboots. This is from a failure of
> construct_alloc_key() to decrement the key's reference count after the attempt
> to insert into the requested keyring is rejected.
> key_put() needs to be called in the link_prealloc_failed callpath to ensure
> the unused key is released.
> Signed-off-by: David Jeffery <djeffery@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>


James Morris

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at