Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable
From: Cass May
Date: Mon Feb 16 2015 - 09:46:26 EST
On Mon, 2015-02-16 at 12:12 +0300, Dan Carpenter wrote:
> On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> > Clean up Makefile by removing unnecessary definition of DG_NAME.
> > Signed-off-by: Cass May <cass@xxxxxxxxx>
> > ---
> > Having done some build tests, it seems that DG_NAME is not needed,
> > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former,
> > and moved the latter into the appropriate header.
> Don't resend; this patch is great. But next time just fold both patches
> together into one patch. It's all part of the same fix really so it
> falls into the "one thing per patch" rule.
> dan carpenter
Shall do! Thank you for the guidance.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/