Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs
From: Tom Huynh
Date: Mon Feb 16 2015 - 11:12:42 EST
On Mon, Feb 09, 2015 at 09:40:19PM +0100, Andi Kleen wrote:
> > I'll NAK any external 'download area' (and I told that Andi
> > before): tools/perf/event-tables/ or so is a good enough
> > 'download area' with fast enough update cycles.
> The proposal was to put it on kernel.org, similar to how
> external firmware blobs are distributed. CPU event lists
> are data sheets, so are like firmware. They do not
> follow the normal kernel code licenses. They are not
> source code. They cannot be reviewed in the normal way.
Could you provide more details about the license and review
concern? How are the event list files different from hardware-
specific information (e.g. reg mapping) in header files?
> > If any 'update' of event descriptions is needed it can
> > happen through the distro package mechanism, or via a
> > simple 'git pull' if it's compiled directly.
> > Lets not overengineer this with any dependence on an
> > external site and with a separate update mechanism - lets
> > just get the tables into tools/ and see it from there...
> That experiment has been already done for oprofile,
> didn't work very well.
Please excuse my ignorance, could you say exactly what didn't
work well for oprofile?
Ingo's suggestion seems good to me because these event files
will be transparent to the users, and it's just more
convenient not having to go to a website to look for
the event file that matches the machine to download.
The distro package or the perf make mechanism can put these
files into the appropriate directory. The users who are not
perf developers won't need to know about these files.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/