Re: linux-next: Tree for Feb 17 (i2c-designware-baytrail.c)

From: Randy Dunlap
Date: Tue Feb 17 2015 - 13:28:22 EST


On 02/16/15 21:02, Stephen Rothwell wrote:
> Hi all,
>
> Please do not add any material destined for v3.21 to your linux-next
> included trees until after v3.20-rc1 has been released.
>
> Changes since 20150216:
>

on i386, when CONFIG_IOSF_MBI=m and
CONFIG_I2C_DESIGNWARE_BAYTRAIL=y:

drivers/built-in.o: In function `i2c_dw_eval_lock_support':
(.text+0x37dd74): undefined reference to `iosf_mbi_available'
drivers/built-in.o: In function `reset_semaphore.isra.1':
i2c-designware-baytrail.c:(.text+0x37ddd1): undefined reference to `iosf_mbi_read'
i2c-designware-baytrail.c:(.text+0x37de13): undefined reference to `iosf_mbi_write'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37df26): undefined reference to `iosf_mbi_write'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37dfab): undefined reference to `iosf_mbi_read'
drivers/built-in.o: In function `baytrail_i2c_acquire':
(.text+0x37e080): undefined reference to `iosf_mbi_read'


because IOSF_MBI is tristate and I2C_DESIGNWARE_BAYTRAIL is bool:

config I2C_DESIGNWARE_BAYTRAIL
bool "Intel Baytrail I2C semaphore support"
depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI


I suppose someone could make that:

depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI

or even make I2C_DESIGNWARE_BAYTRAIL be a tristate symbol.


--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/