Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs

From: Pavel Machek
Date: Tue Feb 17 2015 - 13:50:21 EST


Hi!

> This permits to reassign input LEDs to something else than keyboard "leds"
> state, by adding a trigger and a led for each input leds, the former being
> triggered by EV_LED events, and the latter being by default triggered by the
> former. The user can then make the LED use another trigger, including other LED
> triggers of the same keyboard.
>
> The hardware LEDs are now not actioned from the EV_LED event any more, but from
> the per-device LED layer.

I applied patches on top of 3.20-rc0. Note that capslock LED was broken _before_ this change
on both thinkpad and desktop, and that Numlock on thinkpad did crazy stuff _before_ this
change, too.

In default configuration, everything works as before. (Good).

echo kbd-numlock > vt::capsl/trigger makes capslock led stay on after cycling the led
(on thinkpad). heartbeat trigger works.

echo heartbeat > input4::capsl/trigger has expected effect.

echo heartbeat > input4::numl/trigger does not seem to have any effect.

Ok, it seems that numlock is just being handled specially on thinkpad (it also means
uio keys change meaning), I guess that's nothing to worry about.

Tested-by: Pavel Machek <pavel@xxxxxx>

Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/