Re: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2

From: Sebastian Hesselbarth
Date: Wed Feb 18 2015 - 05:42:03 EST

On 18.02.2015 11:33, Antoine Tenart wrote:
On Wed, Feb 18, 2015 at 11:29:50AM +0100, Sebastian Hesselbarth wrote:
On 11.02.2015 17:15, Antoine Tenart wrote:
- chip: chip-control@ea0000 {
- compatible = "marvell,berlin2-chip-ctrl";
- #clock-cells = <1>;
- #reset-cells = <2>;
+ chip: chip-controller@ea0000 {
+ compatible = "marvell,berlin2-chip-ctrl", "syscon";
reg = <0xea0000 0x400>;
+ #clock-cells = <1>;

I noticed just now, but we should either have all of clock, reset,
pinctrl as sub-nodes or none. Currently, this has pinctrl and reset
as sub-nodes but clock hooked up to chip-controller.

Of course. The clock rework is part of the other series[1] which
modifies the clock driver to use regmap but also move the clock into
its own sub-node.

Ah, ok. I misinterpreted the addition of #clock-cells above, but it
gets removed and re-added again.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at