Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core
From: Felipe Balbi
Date: Wed Feb 18 2015 - 09:34:43 EST
On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote:
> This looks correct, but if you are still going to make a new series fixing
> Felipe's comments then the following tiny nitpicks could be fixed as well.
> Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Felipe, Do you want to take this series through your tree?
I can, no issues :-)
> On 17.02.2015 07:41, Sneeker Yeh wrote:
> > +static void xhci_try_to_clear_csc(struct usb_hcd *hcd, int dev_port_num)
> Either add a function description explaining something like "Late
> clearing of connect status.
> Some quirky hardware will suspend the controller when CSC bit is
> cleared and leave URBs unhandled"
> Or change the function name to something like
> xhci_late_csc_clear_quirk() or xhci_deferred_csc_clear_quirk()
I have a feeling xhci_late_csc_clear_quirk() is a better name, much more
descriptive than xhci_try_to_clear_csc() :-)
Description: Digital signature