Re: [PATCH RESEND] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c
From: Ingo Molnar
Date: Wed Feb 18 2015 - 13:07:01 EST
* nick <xerofoify@xxxxxxxxx> wrote:
> On 2015-02-16 02:55 AM, Ingo Molnar wrote:
> > * Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
> >> This changes the structure sta2x11_dma_ops stucture to
> >> use switolb_dma_supported as it's function for
> >> dma_supported hardware verus setting this value to NULL
> >> as this should be set correctly for when dma_supported
> >> function needs to be called for this hardware. Otherwise
> >> this will cause a bug that will crash a operation needing
> >> to access this function if an intended hardware operation
> >> needs to call it but the kernel has the function pointer
> >> for this structure set to NULL incorrectly.
> > This is a pretty vague description - what specific hardware
> > is affected and how is the bug triggered?
> > Thanks,
> > Ingo
> I am unaware of any hardware exactly that this effects.
> However this should be fixed as a preventive feature in
> order to avoid future bugs related to hardware that need
> this function to be supported by the kernel. If you wish
> I can rewrite the commit message stating this instead of
> my earlier commit message.
Fair enough, and yes, adding that info would be nice - just
appending your explanation would do the trick for me!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/