Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings

From: Bryan O'Donoghue
Date: Thu Feb 19 2015 - 05:31:42 EST

On 19/02/15 10:25, Ingo Molnar wrote:

- ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
+ return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
reg++, &imr->wmask);
- if (ret)
- return ret;
- return 0;


This flow was a change asked for and supplied in review
feedback for Andy Shevchenko so NAK to this patch.

But this pattern:

if (ret)
return ret;

return 0;

makes very little sense. Why is it done?



Feedback at review was that it's more consistent with the code that comes before.

So I changed it from

return iosf_mbi_read


ret = iosf_mbi_read

if (ret)
return ret;
return 0;

as a result. I'm OK with the change suggested by the script if Andy (who requested the change) is.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at