Re: [RESEND PATCH] ipv4: ip_check_defrag should correctly check return value of skb_copy_bits

From: Eric Dumazet
Date: Thu Feb 19 2015 - 09:50:23 EST

On Thu, 2015-02-19 at 12:26 +0300, Alexander Drozdov wrote:
> skb_copy_bits() returns zero on success and a negative value on error,
> so it is needed to invert the condition in ip_check_defrag().
> Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before unsharing")
> Signed-off-by: Alexander Drozdov <al.drozdov@xxxxxxxxx>
> Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---
> net/ipv4/ip_fragment.c | 2 +-

No need to resend, your first patch is still active in patchwork.
David is probably traveling from Ottawa.

vi +100 Documentation/networking/netdev-FAQ.txt

Q: I sent a patch and I'm wondering what happened to it. How can I tell
whether it got merged?

A: Start by looking at the main patchworks queue for netdev:

The "State" field will tell you exactly where things are at with
your patch.

Q: The above only says "Under Review". How can I find out more?

A: Generally speaking, the patches get triaged quickly (in less than 48h).
So be patient. Asking the maintainer for status updates on your
patch is a good way to ensure your patch is ignored or pushed to
the bottom of the priority list.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at