Re: [PATCH 1/2] x86: fix output of show_stack_log_lvl()
From: Borislav Petkov
Date: Thu Feb 19 2015 - 19:07:20 EST
On Thu, Feb 19, 2015 at 11:43:15PM +0100, Adrien Schildknecht wrote:
> Prepend the log level at the message following a newline.
> It is not possible to use pr_cont after a newline, the log level will be
> Signed-off-by: Adrien Schildknecht <adrien+dev@xxxxxxxxxxx>
> arch/x86/kernel/dumpstack_32.c | 9 ++++++---
> arch/x86/kernel/dumpstack_64.c | 9 ++++++---
> 2 files changed, 12 insertions(+), 6 deletions(-)
So those two patches belong into one as they logically are one fix.
Please merge them.
Then, please change your commit message to the format:
"Problem is A.
We need to do B.
This patch does it or this patch does C in order fix it."
Something like that in free form. Being verbose is a good thing when
explaning why this fix is needed and for people looking at those commit
messages months and years from now.
ECO tip #101: Trim your mails when you reply.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/