Re: [PATCH] clockevents: Add (missing) default case for switch blocks
From: Peter Zijlstra
Date: Fri Feb 20 2015 - 06:38:10 EST
On Fri, Feb 20, 2015 at 10:36:59AM +0100, Ingo Molnar wrote:
> > But it does mean we need to be able to add values to the
> > enum.
> So I'm confused: if we are using proper callbacks (like my
> example outlined) , why is a 'mode enum' needed at all?
Ah, its because the enum is shared between two different use-cases. The
one is the clockevent driver for the clock_event_device::set_mode()
call, and one is the clockevent core call: clockevent_set_mode().
The previous patch changed the driver interface, but retained the
sharing of the enum across both interfaces.
Maybe we should break that enum into two; one for devices and one for
the core interface and avoid the problem that way.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/