Re: [RFT PATCH v2 2/2] compal-laptop: Check return value of power_supply_register
From: Krzysztof Kozlowski
Date: Fri Feb 20 2015 - 08:12:14 EST
On piÄ, 2015-02-20 at 14:04 +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
> Fix this by checking return status of power_supply_register() call. In
> case of failure, clean up sysfs entries and fail the probe.
> @@ -1072,6 +1074,7 @@ static int compal_remove(struct platform_device *pdev)
> data = platform_get_drvdata(pdev);
> + /* FIXME: missing hwmon_device_unregister() */
> sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group);
Crap, I forgot to remove the FIXME note. It is no longer needed because
patch 1 fixes this.
I'll resend. Sorry for the noise.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/