Re: [PATCH v2] mmc: dw_mmc: fix bug that cause mmc_test failture
From: Doug Anderson
Date: Fri Feb 20 2015 - 16:43:29 EST
On Thu, Feb 19, 2015 at 6:55 PM, Addy Ke <addy.ke@xxxxxxxxxxxxxx> wrote:
> The STOP command can terminate a data transfer between a memory card and
> mmc controller.
> As show in Synopsys DesignWare Cores Mobile Stroage Host Databook:
> Data timeout and Data end-bit error will terminate further data transfer
> by mmc controller. So we should not send abort command to terminate a
> data transfer again if we got DRTO and EBE interrupt.
> After this patch, all mmc_test cases can pass on RK3288-Pink2 board.
> Signed-off-by: Addy Ke <addy.ke@xxxxxxxxxxxxxx>
> Changes in v2:
> - DRTO and EBE are both set, should not send abort command too,
> suggested by Doug Anderson.
> drivers/mmc/host/dw_mmc.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
I also suggested that you change the subject to "mmc: dw_mmc: fix
mmc_test by not sending abort for DRTO / EBE errors" which you didn't
do. ...I guess that's not critical. Perhaps Jaehoon (who is
collecting patches for Ulf now I think) can adjust the subject when he
In any case, v2 fixes my problems and seems OK to me.
Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
On rk3288 on a 3.14 kernel w/ lotsa backports:
Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/