Re: [PATCH 06/27] power: wakeup: Remove use of seq_printf return value
From: Pavel Machek
Date: Mon Feb 23 2015 - 06:57:15 EST
On Sun 2015-02-22 13:52:58, Joe Perches wrote:
> On Sun, 2015-02-22 at 22:38 +0100, Pavel Machek wrote:
> > On Sat 2015-02-21 18:53:33, Joe Perches wrote:
> > > The seq_printf return value, because it's frequently misused,
> > > will eventually be converted to void.
> > >
> > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
> > > seq_has_overflowed() and make public")
> > You've just removed overflow handling from
> > print_wakeup_source_stats.
> > Can you explain why that is good idea?
> If overflow occurs, the seq_file subsystem allocates
> a bigger buffer and calls the show function again.
> See Al's comment in the 0/n patch and here:
You may want to explain while this is good idea in the changelog.
>From your explanation it looks like error is somehow handled
on higher-level retry, but...
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/