Re: [PATCH 2/2] ASoC: pcm512x: Allow independently overclocking PLL, DAC and DSP

From: Mark Brown
Date: Mon Feb 23 2015 - 09:32:46 EST

On Sun, Feb 22, 2015 at 12:24:12AM +0000, Peter Rosin wrote:

> ...but I'm not sure everybody agrees that overclocking games should
> be allowed by any and all users?

I don't see why not, ASoC controls are already way beyond end user a lot
of the time.

> If you still want me to convert to ALSA controls, what control do you
> suggest? SOC_SINGLE_EXT? Or should I use an enumeration, because
> mixers tend to present volume controls as a percentage of max, which
> will be confusing: You are now at "volume" 75% (of max 40), when the
> value is 30. Eeek. But enumerations from 0% to 40% sounds tedious.

I'd just use a single value, it's a UI problem with the mixer and if the
control isn't called "Volume" that shouldn cause the UI to not present
it as a volume. He said hopefully.

Or possibly a binary control I guess which would have the nice side
effect of hiding from most non-specialist UIs.

> And how would you suggest that I name the controls?
> "Max Overclock DAC", "Max Overclock DSP" and "Max Overclock PLL"?

Those sound reasonable.

> BTW, the only troubles I've had with overclocking "too much" is that it
> has stopped working. I have not managed to fry any chip. But that is no
> guarantee, of course.

It's vanishingly unlikely that you'll cause physical damage with this
sort of thing, you're much more likely to hit performance and filter
problems than anything else.

Attachment: signature.asc
Description: Digital signature