Re: [PATCH v3] ARM: pxa: fix pxa interrupts handling in DT
From: Robert Jarzmik
Date: Mon Feb 23 2015 - 16:42:09 EST
Robert Jarzmik <robert.jarzmik@xxxxxxx> writes:
> The commit "ARM: pxa: arbitrarily set first interrupt number" changed
> the first pxa interrupt to 16.
> As a consequence, device-tree builds got broken, because :
> - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT()
> - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0)
> Before the commit, the first interrupt shift, PXA_IRQ(0) was 0,
> therefore IRQ_BIT(x) was x. After the change, it is necessary that the
> same shift of 16 is applied between the virtual interrupt number and the
> hardware irq number.
> This situation comes from the common irq_chip shared between legacy
> platform builds and device-tree builds.
> Fix the broken interrupts in DT case by adding this shift in the DT case
> As a consequence of the IRQ_BIT() is removed alltogether from interrupts
> handling, even in the platform data types of platforms :
> - a legacy irq domain is used
> - the irq_chip handles hardware interrupts
> - the virtual to hardware interrupt conversion is fully handled by irq
> domain mechanics
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Queued in pxa/fixes.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/