Re: [PATCH] powerpc: Update all configs using savedefconfig

From: Michael Ellerman
Date: Mon Feb 23 2015 - 19:11:30 EST


On Mon, 2015-02-23 at 10:59 +0100, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Tue, Jan 20, 2015 at 8:05 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> > It looks like it's ~4 years since we updated some of these, so do a bulk
> > update.
> >
> > Verified that the before and after generated configs are exactly the
> > same.
>
> Yep, that's guaranteed by the tool (modulo bugs).
>
> > Which begs the question why update them? The answer is that it can be
> > confusing when the stored defconfig drifts too far from the generated
> > result.
>
> And it becomes hard to update them, e.g. for enabling or disabling a single
> option.
>
> Now the big question is: do they still work?
> Plainly ignoring any bugs introduced in the code, there are probably several
> "select" statements that have been removed. 4 years ago, they automatically
> selected some critical options, while now, they're no longer selected, causing
> breakage.

Yeah true. So far no one has yelled at me, so perhaps we got lucky :)

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/