Re: [PATCH v3 linux-next] iommu: Enable LPAE pagetable on ARM and ARM64 only

From: Laurent Pinchart
Date: Mon Feb 23 2015 - 19:22:50 EST


On Tuesday 24 February 2015 01:20:21 Vincent Stehlé wrote:
> LPAE iommu page table makes sense only for ARM and ARM64 architectures. Add
> the corresponding dependency in Kconfig (and enable for COMPILE_TEST, too,
> as per Laurent's suggestion).
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@xxxxxxxxxxx>
> Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>

Now,

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>
> On 02/24/2015 01:02 AM, Laurent Pinchart wrote:
> > Shouldn't this be ARM || ARM64 || COMPILE_TEST ?
>
> Hi Laurent,
>
> It makes perfect sense; thanks. I completely forgot, as I have yet to see
> one of those. Here is v3 of the patch.
>
> Best regards,
>
> V.
>
>
> Changes since v2:
> - Add condition on ARM64
>
> Changes since v1:
> - Add condition on COMPILE_TEST
>
>
> drivers/iommu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index baa0d97..a440922 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -22,6 +22,7 @@ config IOMMU_IO_PGTABLE
>
> config IOMMU_IO_PGTABLE_LPAE
> bool "ARMv7/v8 Long Descriptor Format"
> + depends on ARM || ARM64 || COMPILE_TEST
> select IOMMU_IO_PGTABLE
> help
> Enable support for the ARM long descriptor pagetable format.

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/