Re: [PATCH v4 2/8] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

From: Chanwoo Choi
Date: Tue Feb 24 2015 - 03:52:08 EST


On 02/24/2015 05:35 PM, Arnd Bergmann wrote:
> On Tuesday 24 February 2015 14:16:45 Chanwoo Choi wrote:
>> + aliases {
>> + pinctrl0 = &pinctrl_alive;
>> + pinctrl1 = &pinctrl_aud;
>> + pinctrl2 = &pinctrl_cpif;
>> + pinctrl3 = &pinctrl_ese;
>> + pinctrl4 = &pinctrl_finger;
>> + pinctrl5 = &pinctrl_fsys;
>> + pinctrl6 = &pinctrl_imem;
>> + pinctrl7 = &pinctrl_nfc;
>> + pinctrl8 = &pinctrl_peric;
>> + pinctrl9 = &pinctrl_touch;
>> + serial0 = &serial_0;
>> + serial1 = &serial_1;
>> + serial2 = &serial_2;
>> + i2c0 = &hsi2c_0;
>> + i2c1 = &hsi2c_1;
>> + i2c2 = &hsi2c_2;
>> + i2c3 = &hsi2c_3;
>> + i2c4 = &hsi2c_4;
>> + i2c5 = &hsi2c_5;
>> + i2c6 = &hsi2c_6;
>> + i2c7 = &hsi2c_7;
>> + i2c8 = &hsi2c_8;
>> + i2c9 = &hsi2c_9;
>> + i2c10 = &hsi2c_10;
>> + i2c11 = &hsi2c_11;
>> + };
>> +
>>
>
> Can you put the aliases into the per-board files? There might be boards that
> do not support all the uarts and all the i2c controllers but only want to
> provide aliases for a subset of them, without holes in the numbering.

OK, I'm not opposite with you opinion.

But, I have a question.
If we put the aliases into the board dts file instaed of SoC dtsi,
each board dts file may use the different alias name about same phandle.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/