Re: [PATCH 1/2] ASoC: core: Add extra dapm properties for Device Tree

From: Mark Brown
Date: Tue Feb 24 2015 - 09:48:26 EST


On Sat, Feb 14, 2015 at 05:22:49PM -0800, Nicolin Chen wrote:
> The current helper functions, snd_soc_of_parse_audio_simple_widgets()
> and snd_soc_of_parse_audio_routing(), set dapm_widgets and dapm_routes
> without caring if they are already set by using build-in widgets and
> routes in the card driver. So there could be one of them, build-in one
> or Device Tree one, overrided by the other depending on which one was
> assigned later.

Applied both, thanks. This doesn't feel terribly elegant (what happens
with ACPI and with whatever else?) but it does the job and we can always
refactor it to be neater later. Or perhaps just rename the variable
which may actually be all that's needed.

Attachment: signature.asc
Description: Digital signature