Re: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC

[Greg KH]

On Fri, Feb 20, 2015 at 06:43:53PM +0530, Tapasweni Pathak wrote:
> To avoid deadlock, do not call blocking functions with spinlocks held.
> 
> Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
> doesn't have enough free pages but will not sleep and hence deadlock can
> be avoided.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@xxxxxxxxx>
> ---
> Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?

No, this is fine, nice fix.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/