Re: [PATCH] media: em28xx replace printk in dprintk macros

From: Joe Perches
Date: Tue Feb 24 2015 - 22:46:15 EST


On Tue, 2015-02-24 at 16:41 -0700, Shuah Khan wrote:
> On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote:
> > Em Tue, 24 Feb 2015 11:53:47 -0700 Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu:
> >> Replace printk macro in dprintk macros in em28xx audio, dvb,
> >> and input files with pr_* equivalent routines.
[]
> >> diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c
[]
> >> #define dprintk(fmt, arg...) \
> >> if (ir_debug) { \
> >> - printk(KERN_DEBUG "%s/ir: " fmt, ir->name , ## arg); \
> >> + pr_debug("%s/ir: " fmt, ir->name, ## arg); \
> >
> > NACK.
> >
> > This is the worse of two words, as it would require both to enable
> > each debug line via dynamic printk setting and to enable ir_debug.
> Ah. I missed that. Sorry for the noise.

It's
At some point, I'm going to propose a standard mechanism
similar to netif_<level> that does bitmap matching for
dynamic_debug and generic debugging.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/