Re: [PATCH 0/3] lib/vsprintf: Doc improvements and clock support

From: Geert Uytterhoeven
Date: Fri Feb 27 2015 - 02:52:29 EST


Hi Stephen,

On Fri, Feb 27, 2015 at 1:02 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> On 02/26/15 03:13, Geert Uytterhoeven wrote:
>> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> This patch series improves the documentation for printk() formats, and
>> adds support for printing clocks. The latter has always been a hassle if
>> you wanted to support both the common and legacy clock frameworks.
>
> Would the hassle go away if everyone moved to the common framework? I'm

Not anymore, now clk->name is gone ;-)

> mostly trying to understand the justification.

As a driver writer, once in a while I need to print out names and rates for
clocks and their parents from driver debug code.
As before this involved including clk_private.h and having #ifdefs to
support both
legacy and CCF, that debug code was alwas stripped from drivers before
submission, and never went upstream.

> Also, I wonder why we wouldn't want to add formats for all the other
> handle based frameworks that we have nowdays (gpio, regulator, pinctrl,
> etc.).

If someone feels the need to print those, support can be added.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/