Re: [RFC][PATCH] module: Optimize __module_address() using a latched RB-tree

From: Rusty Russell
Date: Fri Feb 27 2015 - 07:11:35 EST


Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
> One of the users of this is __kernel_text_address() which is employed in
> many stack unwinders; which in turn are used by perf-callchain (possibly
> from NMI context).

Um, so the stack unwinders use "does this look like a kernel address"
because we omit the frame pointer?

To keep that optimization, we add 220 non-trivial lines to module.c?

Don't get me wrong, it's cute code, but I do wonder if at some point a
grown up is going to come along and tell us to stop :)

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/