Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

[Sergei Shtylyov]

Hello.

On 2/27/2015 5:17 PM, Robert Abel wrote:

> >     Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
> > parameter names, doesn't it?

> Jesus Christ, you guys are killing me...
> I've already spent way more time on this patch series than I intended
> to anyway...

   That's what you get when pushing your stuff upstream. You're not alone 
here. :-)

> > > +       mask = (1 << nr_bits) - 1;

> >     BIT(nr_bits) - 1, perhaps?

> Not happening... BIT macro obscures what's actually going on.

   I did search for a macro that does ((1 << n) - 1) but didn't found it, 
unfortunately...

> Regards,
> Robert

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/