Re: [PATCH v6 1/2] tools lib traceevent: factor out allocating and processing args

[Javi Merino]

On Fri, Feb 27, 2015 at 03:38:41PM +0000, Steven Rostedt wrote:
> On Fri, 27 Feb 2015 14:48:14 +0000
> Javi Merino <javi.merino@xxxxxxx> wrote:
> 
>   
> > +static int alloc_and_process_arg(struct event_format *event, char *next_token,
> > +				 struct print_arg **print_arg)
> > +{
> > +	struct print_arg *field;
> > +	enum event_type type;
> > +	char *token;
> > +	int ret = 0;
> > +
> > +	field = alloc_arg();
> > +	if (!field) {
> > +		do_warning_event(event, "%s: not enough memory!", __func__);
> > +		errno = ENOMEM;
> > +		return -1;
> > +	}
> > +
> > +	type = process_arg(event, field, &token);
> > +
> > +	if (test_type_token(type, token, EVENT_DELIM, next_token)) {
> 
> I wonder if we should call this "alloc_and_process_delim()", as this
> isn't a generic arg, but only used for deliminators.

Ok, I'll send a v7 renaming this function.

Cheers,
Javi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/