Re: [PATCH 2/2] livepatch: fix patched module loading race

From: Josh Poimboeuf
Date: Wed Mar 04 2015 - 17:46:45 EST


On Wed, Mar 04, 2015 at 11:02:59PM +0100, Jiri Kosina wrote:
> On Wed, 4 Mar 2015, Josh Poimboeuf wrote:
>
> > Well, we could just get a reference on all patched modules to prevent them
> > from being unloaded.
>
> Is that really a solution for cases where you are unloading a module (it
> has "just" been switched to MODULE_STATE_GOING) and enable a patch which
> patches one of its functions directly after it got switched to
> MODULE_STATE_GOING?

Ah, right. try_module_get() fails, we don't patch the module, and we
end up in the same mod->exit() race. Never mind, again :-)

--
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/