Re: [PATCH v4] spi: qup: Add DMA capabilities

From: Lars-Peter Clausen
Date: Sun Mar 08 2015 - 07:21:41 EST


On 03/07/2015 08:43 PM, Andy Shevchenko wrote:
On Sat, Mar 7, 2015 at 1:21 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
On Wed, Mar 04, 2015 at 12:02:05PM +0200, Stanimir Varbanov wrote:
From: Andy Gross <agross@xxxxxxxxxxxxxx>

This patch adds DMA capabilities to the spi-qup driver. If DMA channels are
present, the QUP will use DMA instead of block mode for transfers to/from SPI
peripherals for transactions larger than the length of a block.

Applied, but why is there no devm_dma_request_slave_channel_reason()?

I suppose the answer would be "we have a lot of slightly different
cases and we have to get rid of current mess with legacy API calls".
The most problematic stuff now inside DMA slave subsystem is so called
"filter function". It's a main impediment right now as I understand.

dma_request_slave_channel_reason() is the sane API though and does not use the filter functions. Adding a devm version of it seems reasonable.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/