Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

From: Srinivas Kandagatla
Date: Mon Mar 09 2015 - 03:13:30 EST

On 07/03/15 15:00, Mark Brown wrote:
On Thu, Mar 05, 2015 at 09:45:41AM +0000, Srinivas Kandagatla wrote:

+ return eeprom;

This framework uses regmap but regmap is EXPORT_SYMBOL_GPL() and this is

Thanks for spotting this, I will fix this in next version.

+int eeprom_unregister(struct eeprom_device *eeprom)
+ mutex_lock(&eeprom_mutex);
+ if (atomic_read(&eeprom->users)) {
+ mutex_unlock(&eeprom_mutex);

Atomic reads and a mutex - isn't the mutex enough? Atomics are
generally a recipie for bugs due to the complexity in using them.
Yes, you are right as long as we protect users variable with mutex, using atomic is really redundant, will fix it in next version.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at