Re: [PATCH 2/2] x86: save user %rsp in pt_regs->sp on SYSCALL64 fastpath

From: Ingo Molnar
Date: Mon Mar 09 2015 - 12:19:16 EST



* Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:

> PER_CPU(old_rsp) usage is simplified - now it is used only
> as temp storage, and userspace stack pointer is immediately stored
> in pt_regs->sp on syscall entry, instead of being used later,
> on syscall exit.
>
> All references of PER_CPU(old_rsp) in C code are gone -
> pt_regs->sp is used instead.
>
> This also allows to get rid of thread_struct::usersp,
> which was needed only to set PER_CPU(old_rsp) for
> correct return from fork/clone.

Would it be possible to split this one into two parts as well:

- Essential changes into the first one (old_rsp update
simplification, usersp usage conversion)

- Removal of usersp, old_rsp extern declaration removal, comment
changes, in the second patch?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/