[PATCH v2] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

From: Denys Vlasenko
Date: Mon Mar 09 2015 - 12:44:47 EST

Old code was trying to avoid having three branch insns,
but instead it has a chain of six insns where each insn
depends on previos one.

And it was touching PT_OLDSS(%esp) unconditionally, even when it may
contain bogus data. Elsewhere we have to jump thru hoops
just to make sure here PT_OLDSS(%esp) is at least in a valid page.

All this just to have one branch instead of three?

The new code simply checks each condition.
All three checks can run in parallel on an out-of-order CPU.
Most of the time, none of branches will be taken.

Comparison of object code:
1e6: 8b 44 24 38 mov 0x38(%esp),%eax
1ea: 8a 64 24 40 mov 0x40(%esp),%ah
1ee: 8a 44 24 34 mov 0x34(%esp),%al
1f2: 25 03 04 02 00 and $0x20403,%eax
1f7: 3d 03 04 00 00 cmp $0x403,%eax
1fc: 74 0f je 20d <ldt_ss>
1e6: f6 44 24 3a 02 testb $0x2,0x3a(%esp)
1eb: 75 0e jne 1fb <restore_nocheck>
1ed: f6 44 24 34 03 testb $0x3,0x34(%esp)
1f2: 74 07 je 1fb <restore_nocheck>
1f4: f6 44 24 40 04 testb $0x4,0x40(%esp)
1f9: 75 0f jne 20a <ldt_ss>

Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
CC: Ingo Molnar <mingo@xxxxxxxxxx>
CC: Borislav Petkov <bp@xxxxxxxxx>
CC: "H. Peter Anvin" <hpa@xxxxxxxxx>
CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
CC: Oleg Nesterov <oleg@xxxxxxxxxx>
CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
CC: Alexei Starovoitov <ast@xxxxxxxxxxxx>
CC: Will Drewry <wad@xxxxxxxxxxxx>
CC: Kees Cook <keescook@xxxxxxxxxxxx>
CC: x86@xxxxxxxxxx
CC: linux-kernel@xxxxxxxxxxxxxxx
Changes since v1:
shorter insn to test EFLAGS.VM (suggested by Linus)
check EFLAGS.VM only if CONFIG_VM86

arch/x86/kernel/entry_32.S | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index e33ba51..d185b5e 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -516,16 +516,17 @@ restore_all:
#ifdef CONFIG_X86_ESPFIX32
- movl PT_EFLAGS(%esp), %eax # mix EFLAGS, SS and CS
- # Warning: PT_OLDSS(%esp) contains the wrong/random values if we
- # are returning to the kernel.
- # See comments in process.c:copy_thread() for details.
- movb PT_OLDSS(%esp), %ah
- movb PT_CS(%esp), %al
- andl $(X86_EFLAGS_VM | (SEGMENT_TI_MASK << 8) | SEGMENT_RPL_MASK), %eax
- cmpl $((SEGMENT_LDT << 8) | USER_RPL), %eax
- je ldt_ss # returning to user-space with LDT SS
+#ifdef CONFIG_VM86
+ testb $2, (PT_EFLAGS+2)(%esp)
+ jnz restore_nocheck # EFLAGS.VM set, not it
+ testb $3, PT_CS(%esp)
+ jz restore_nocheck # CPL0, not it
+ # Note: we access PT_OLDSS only when we know it exists.
+ # If PT_CS is from CPL0, it does not exist.
+ testb $SEGMENT_LDT, PT_OLDSS(%esp)
+ jnz ldt_ss # returning to user-space with LDT SS
RESTORE_REGS 4 # skip orig_eax/error_code

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/