Re: [PATCH] staging: sm750fb: Fix sparse warning

From: Sudip Mukherjee
Date: Tue Mar 10 2015 - 03:42:42 EST

On Mon, Mar 09, 2015 at 08:57:08PM +0000, Lorenzo Stoakes wrote:
> +#include <asm/io.h>
> +
apart from what Dan Carpenter has said,
this is introducing one checkpatch warning, better to use #include <linux/io.h>
checkpatch is also giving warning about your patch subject

only one concern - if Greg first applies the patches i sent yesterday then this patch will not apply, and if this one is applied first then my series will not apply ...


> /* This is all the chips recognized by this library */
> mmio750 = addr;
> devId750 = devId;
> --
> 2.3.2
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at