Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

From: Ivan T. Ivanov
Date: Tue Mar 10 2015 - 04:11:10 EST

On Mon, 2015-03-09 at 18:28 +0000, Mark Brown wrote:
> On Mon, Mar 09, 2015 at 10:23:35AM +0200, Ivan T. Ivanov wrote:
> > Hi,
> Don't reply off list unless there's a good reason...

Sorry, it was not intentional. Wrong button.

> > > Any new GPIO users should really be using the gpiod API, however this is
> > > duplicating core functionality so as Stephen says why are we doing this?
> > About the API usage, point taken. GPIO requesting part is more important
> > in this case. pinctrl core did not request pins and wrong DT configuration
> > could lead to surprises without any warnings or errors.
> That doesn't answer my concern at all.

I am not sure that I am following you.

I can not use spi_master::cs_gpios, which is populated by
of_spi_register_master(), because spi_register_master()
populate SPI devices and they could issue setup method.

Requesting GPIO's in core framework is also not a easy
option because of arguments here[1].

Probably I am still missing something.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at