Re: [PATCH] staging: sm750fb: Fix sparse warning
From: Dan Carpenter
Date: Tue Mar 10 2015 - 04:59:39 EST
On Tue, Mar 10, 2015 at 08:47:47AM +0000, Lorenzo Stoakes wrote:
> On 10 March 2015 at 07:00, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > No need for the volatile.
> Will remove.
> > Really mmio750 should be a "void __iomem *"
> > it is declared as "unsigned char __iomem *" but it's not a char pointer
> > that's only to make the pointer math work. It would work just as well
> > as a void and we could remove some ugly casting.
> I'm thinking the change to "void __iomem *" from "unsigned char
> __iomem *" ought to be a separate patch in order to keep this cleanly
> focused on solving the sparse warning? Am more than happy to do this
> and make the appropriate changes to the macros in ddk750_help.h.
The patch is:
[patch] cleanup the type of mmio750
silencing a Sparse warning is just a side benifit of using correct
data types. The "one thing per patch" rule also means that you should
fix a whole problem instead of half a thing per patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/