[PATCH] perf build: Fix libbabeltrace detection

From: Jiri Olsa
Date: Tue Mar 10 2015 - 08:02:48 EST

On Mon, Mar 09, 2015 at 08:28:45PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 09, 2015 at 08:11:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Mar 09, 2015 at 06:51:21PM -0300, Arnaldo Carvalho de Melo escreveu:


> [root@zoo ~]# find /opt/libbabeltrace/include/babeltrace/ -type f | xargs grep bt_ctf_stream_class_get_packet_context_type
> /opt/libbabeltrace/include/babeltrace/ctf-ir/stream-class.h: * bt_ctf_stream_class_get_packet_context_type: get the stream class' packet
> /opt/libbabeltrace/include/babeltrace/ctf-ir/stream-class.h:extern struct bt_ctf_field_type *bt_ctf_stream_class_get_packet_context_type(
> [root@zoo ~]#
> That seems to be included from the file included in the feature test code :-\
> Really ran out of time now...

ouch, thanks a lot for debugging.. the reason is indeed the -Werror added by:

b49f1a4be701 perf tools: Improve feature test debuggability

following patch seems to fix this for me


Following patch added -Werror for feature builds:
b49f1a4be701 perf tools: Improve feature test debuggability

and broke libbabeltrace feature build, because it was including
wrong header and gcc couldn't find the used symbol definition.

Adding proper header and keeping the old one as it is needed
also (libbabeltrace quirk).

Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
tools/perf/config/feature-checks/test-libbabeltrace.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/config/feature-checks/test-libbabeltrace.c b/tools/perf/config/feature-checks/test-libbabeltrace.c
index 3b7dd68a4d52..9cf802a04885 100644
--- a/tools/perf/config/feature-checks/test-libbabeltrace.c
+++ b/tools/perf/config/feature-checks/test-libbabeltrace.c
@@ -1,5 +1,6 @@

#include <babeltrace/ctf-writer/writer.h>
+#include <babeltrace/ctf-ir/stream-class.h>

int main(void)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/