Re: [PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering

From: Heiko Stuebner
Date: Tue Mar 10 2015 - 08:33:35 EST

Am Dienstag, 10. März 2015, 12:07:50 schrieb Mark Brown:
> On Tue, Mar 10, 2015 at 12:22:06AM +0100, Heiko Stuebner wrote:
> > When {devm_}regulator_get returns -EPROBE_DEFER the driver in question
> > will
> > try probing again at a later time. So don't spam the log with failure
> > messages as this is an expected result of probe ordering.
> >
> > - dev_err(dev, "Failed to get supply '%s': %d\n",
> > - consumers[i].supply, ret);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(dev, "Failed to get supply '%s': %d\n",
> > + consumers[i].supply, ret);
> No, this is not good - you get a nice quiet boot even if the regulator
> does not appear which means people have no idea why the driver isn't
> loading. That's not a good user experience, silent error handling is
> the main problem I see people running into trying to get their systems
> up and running these days.
> Really deferred probe is just fundamentally noisy since it's
> intentionally tolerating errors like this and of course a lot of the
> noise comes from the deferral messages the core prints.

ok, I'll drop this one then

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at