Re: [PATCH RFC] leds: Add status code trigger

From: Pavel Machek
Date: Tue Mar 10 2015 - 15:22:35 EST


Hi!

> This patch is very similar to mine patten trigger and all features are covered by my patch.
> If you are considering to take this feature, could you consider my patch instead?
> http://thread.gmane.org/gmane.linux.documentation/19116/focus=19135

That one is indeed better than this patch (as it supports almost
arbitrary blinking pattern on single LED, it will not help much with
smooth brightness control.

Would solution below work for you?

Best regards,
Pavel

> > I think I have interface to handle most of the issues: array of
> > integers in "brightness, length in miliseconds".
> >
> > So for example slowly blinking LED would be "0 1000msec, 255 1000
> > msec". On off pattern would be "0 1000msec, 255 0msec, 255 1000msec, 0
> > 0msec".
> >
> > Rapahael, this should be able to do all the stuff you want to do. It
> > can also do morse code, slow blinks, and combination of both. Do you
> > want to try implementing it?
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/