Re: [PATCH] kernfs: remove outdated and confusing comment

From: Tejun Heo
Date: Wed Mar 11 2015 - 07:45:41 EST


On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7
> "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing
> comment.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

> Found while trying to find out why my sysfs-bin file always returns POLLPRI
> after opening, reading, polling. Any pointers while I am here? :)

Hmm... poll isn't hooked up for bin files and the behavior isn't well
defined either. The open file's event counter is never synchronized
to the backing node's. Before the first kernfs_notify(), it won't
trigger and after always. We'll prolly need to define that better.
What's the use case that you're interested in?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/