Re: [PATCH v2 1/3] sysfs: Use only return value from is_visible for the file mode

From: Greg Kroah-Hartman
Date: Thu Mar 12 2015 - 06:00:29 EST

On Wed, Mar 11, 2015 at 02:22:09PM -0400, Vivien Didelot wrote:
> From: Guenter Roeck <linux@xxxxxxxxxxxx>
> Up to now, is_visible can only be used to either remove visibility
> of a file entirely or to add permissions, but not to reduce permissions.
> This makes it impossible, for example, to use DEVICE_ATTR_RW to define
> file attributes and reduce permissions to read-only.
> This behavior is undesirable and unnecessarily complicates code which
> needs to reduce permissions; instead of just returning the desired
> permissions, it has to ensure that the permissions in the attribute
> variable declaration only reflect the minimal permissions ever needed.
> Change semantics of is_visible to only use the permissions returned
> from it instead of oring the returned value with the hard-coded
> permissions.
> Cc: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> fs/sysfs/group.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Why have you not signed off on this patch if you sent it to me? Don't
you agree with it?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at