Re: [RESEND PATCH v6 09/22] mfd: ab8500: Use power_supply_*() API for accessing function attrs

From: Lee Jones
Date: Thu Mar 12 2015 - 08:04:04 EST


On Thu, 12 Mar 2015, Krzysztof Kozlowski wrote:

> On czw, 2015-03-12 at 09:50 +0000, Lee Jones wrote:
> > On Thu, 12 Mar 2015, Krzysztof Kozlowski wrote:
> > > On czw, 2015-03-12 at 09:01 +0000, Lee Jones wrote:
> > > > On Thu, 12 Mar 2015, Krzysztof Kozlowski wrote:
> > > >
> > > > > Replace direct calls to power supply function attributes with wrappers.
> > > > > Wrappers provide safe access in case of unregistering the power
> > > > > supply (e.g. by removing the driver). Replace:
> > > > > - get_property -> power_supply_get_property
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > > > > Acked-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
> > > > > Acked-by: Pavel Machek <pavel@xxxxxx>
> > > > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > > > > Reviewed-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > > > > ---
> > > > > drivers/mfd/ab8500-sysctrl.c | 7 ++++---
> > > > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > > >
> > > > Has the infrastructure for these been merged yet?
> > > >
> > > > I.e. Can I just take them?
> > >
> > > Previous patches were not merged yet so you cannot take it. This whole
> > > patchset can be applied incrementally but cherry picking won't work.
> >
> > So I only usually receive patches I've already Acked when a) the bulk
> > of the set has been merged and I can apply the remaining lingerers, or
> > b) the whole set is due to be applied through the MFD tree.
> >
> > Receiving 2 patches of a 22 patch set, which I have already Acked and
> > that I can't pick is unwelcome noise.
>
> Sorry for the noise, it should not happen.
>
> That is strange, how did you receive this patch? I resent this only to
> certain recipients because previous mail got lost in spam filters (too
> many recipients).
>
> I did not put other maintainers (like you) this time on cc-list.
> git-send-email also did not cc-ed you (your email is not listed in
> send-email log).
>
> How this email managed to get to you? :)

That's a good question. It just arrived in my Inbox.

Anyway, not to worry.

Let me know when the other patches have been merged, so I can apply
these.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/