Re: [PATCH 1/15] NFSv4.1: don't export static symbol

From: Trond Myklebust
Date: Thu Mar 12 2015 - 11:59:41 EST


On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> fs/nfs/pnfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
>
> int
> pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
> @@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
>
> int
> pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
>

Thanks Julia! Applied....

--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/