Re: [PATCH 12/22] sparc: %pF is only for function pointers
From: Scott Wood
Date: Thu Mar 12 2015 - 14:50:02 EST
On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote:
> On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor. Even on
> > other architectures, refrain from setting a bad example that people
> > copy.
> The commit message used uppercase 'S' and 'F'.
> But the patch uses lowercase variants.
> Is this to highlight the letter in the commit message or some unwanted inconsistency?
It was copy and paste from others in the series that did involve the
capital version. I can send a v2 with an updated commit message.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/