Re: [PATCH v2 3/4] hwmon: (lm85) replace x_TO_REG() functions with find_closest()

From: Rasmus Villemoes
Date: Fri Mar 13 2015 - 04:53:24 EST


On Tue, Mar 10 2015, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> wrote:

> Replace RANGE_TO_REG() and FREQ_TO_REG() functions with calls
> to find_closest().
>

I think the other functions you've replaced only had a single caller,
but RANGE_TO_REG is called in two places. It's not a huge function and 2
is not a big number, but maybe it's better to let gcc decide whether to
inline the code. So how about leaving the *_TO_REG functions in place
and just replace their bodies with the appropriate macro invocation?

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/