Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header

From: Ian Abbott
Date: Fri Mar 13 2015 - 06:28:26 EST


On 12/03/15 10:29, Ian Abbott wrote:
On 10/03/15 16:25, Joe Perches wrote:
On Tue, 2015-03-10 at 16:10 +0000, Ian Abbott wrote:
"comedidev.h" includes PCI-specific stuff that gets included by all
comedi drivers including non-PCI ones. Separate it out into its own
header "comedi_pci.h". Make the new header include <linux/pci.h> and
"comedidev.h" so that comedi PCI drivers do not need to include them
explicitly.

Isn't the kernel progressing to avoid indirect includes?

I could do it that way if you think it would help. Better to redo it
before it is committed than after.

I have a v2 series ready to post now, that doesn't use the indirect includes. Should I post that one, Greg, or are you okay with the existing series?

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/