Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

From: Paolo Bonzini
Date: Fri Mar 13 2015 - 09:03:21 EST




On 13/03/2015 00:21, Fam Zheng wrote:
>> I think the bug here is also that virtio-pci
>> is not defining a .shutdown callback. It should define one and call
>> free_irq (for INTX) and pci_disable_msix.
>
> It's not enough. The device has to know we disabled msix, otherwise it will
> send us IRQ, which is wrong.

You can use pci_intx to disable INTX too. So I think this is a
virtio-pci bug.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/