Re: [PATCH] of/unittest: Fix the wrong expected value in of_selftest_property_string

From: Rob Herring
Date: Fri Mar 13 2015 - 11:28:29 EST


On Mon, Mar 2, 2015 at 9:50 PM, Wang Long <long.wanglong@xxxxxxxxxx> wrote:
> This patch fix the wrong expected value of of_property_match_string
> in of_selftest_property_string.
>
> Signed-off-by: Wang Long <long.wanglong@xxxxxxxxxx>

Applied for 4.0. Thanks.

Rob

> ---
> drivers/of/unittest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 199fb23..00ddce7 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -378,9 +378,9 @@ static void __init of_selftest_property_string(void)
> rc = of_property_match_string(np, "phandle-list-names", "first");
> selftest(rc == 0, "first expected:0 got:%i\n", rc);
> rc = of_property_match_string(np, "phandle-list-names", "second");
> - selftest(rc == 1, "second expected:0 got:%i\n", rc);
> + selftest(rc == 1, "second expected:1 got:%i\n", rc);
> rc = of_property_match_string(np, "phandle-list-names", "third");
> - selftest(rc == 2, "third expected:0 got:%i\n", rc);
> + selftest(rc == 2, "third expected:2 got:%i\n", rc);
> rc = of_property_match_string(np, "phandle-list-names", "fourth");
> selftest(rc == -ENODATA, "unmatched string; rc=%i\n", rc);
> rc = of_property_match_string(np, "missing-property", "blah");
> --
> 1.8.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/