Re: [PATCH 3/4] workqueue: Create low-level unbound workqueues cpumask

[Kevin Hilman]

Kevin Hilman <khilman@xxxxxxxxxx> writes:

> Lai Jiangshan <laijs@xxxxxxxxxxxxxx> writes:
>
>> From: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>>
>> Create a cpumask that limit the affinity of all unbound workqueues.
>> This cpumask is controlled though a file at the root of the workqueue
>> sysfs directory.
>>
>> It works on a lower-level than the per WQ_SYSFS workqueues cpumask files
>> such that the effective cpumask applied for a given unbound workqueue is
>> the intersection of /sys/devices/virtual/workqueue/$WORKQUEUE/cpumask and
>> the new /sys/devices/virtual/workqueue/cpumask_unbounds file.
>>
>> This patch implements the basic infrastructure and the read interface.
>> cpumask_unbounds is initially set to cpu_possible_mask.
>>
>> Cc: Christoph Lameter <cl@xxxxxxxxx>
>> Cc: Kevin Hilman <khilman@xxxxxxxxxx>
>> Cc: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>> Cc: Mike Galbraith <bitbucket@xxxxxxxxx>
>> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
>> Cc: Tejun Heo <tj@xxxxxxxxxx>
>> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>
> [...]
>
>> @@ -5094,6 +5116,9 @@ static int __init init_workqueues(void)
>>  
>>  	WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));
>>  
>> +	BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL));
>> +	cpumask_copy(wq_unbound_cpumask, cpu_possible_mask);
>> +
>
> As I mentioned in an earlier discussion[1], I still think this could
> default too the housekeeping CPUs in the NO_HZ_FULL case:
>
> #ifdef CONFIG_NO_HZ_FULL
> 	cpumask_complement(wq_unbound_cpumask, tick_nohz_full_mask);
> #else
> 	cpumask_copy(wq_unbound_cpumask, cpu_possible_mask);
> #endif
>
> But that could also be left to a future optimization as well.

I meant to add:

Acked-by: Kevin Hilman <khilman@xxxxxxxxxx>

as well, as the NO_HZ_FULL bit could be added as an add-on patch.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/