Re: [PATCH v2 net-next 1/2] bpf: allow extended BPF programs access skb fields

From: Alexei Starovoitov
Date: Fri Mar 13 2015 - 22:27:46 EST


On 3/13/15 7:16 PM, Daniel Borkmann wrote:
On 03/14/2015 03:08 AM, Alexei Starovoitov wrote:
On 3/13/15 7:06 PM, Daniel Borkmann wrote:
On 03/14/2015 02:46 AM, Daniel Borkmann wrote:
...
Previously, it was much more consistent, which I like better. And only
because of the simple BUILD_BUG_ON()? :/

Alternative is to move all of them into a central place, something like
in twsk_build_assert() or __mld2_query_bugs[].

nope. that defeats the purpose of bug_on.

Well, it doesn't. ;) It throws a build error thus the user is forced to
investigate that further.

according to this distorted logic all build_bug_on can be in one file
across the whole tree, since 'user is forced to investigate' ?!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/